On Tue, Jul 01, 2014 at 09:27:19AM +0300, Gleb Natapov wrote: > > The vcpu will never see a read-only spte because the VM-exit (due to > > IPI) guarantees vcpu is outside of guest mode _before_ it is write > > protected. > Right. Now I see why you absolutely have to send IPI in mmu_reload_pinned_vcpus() > before marking pte as read only. And kvm->mmu_lock is what will prevent vcpu from > re-entering guest mode again before pte is marked read only, right? Yes. > > So i ask you: do you still hold the "current approach should be > > improved" position ? > > > As I said IMO what I proposed is much simpler and not as tricky as what you have here. > It also has an advantage of not slowing down next guest entry after GET_DIRTY_LOG because > it does not require mmu reload and page_faulting in pinned pages. Ok sure. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
