On 2014-06-16 12:53, Paolo Bonzini wrote: > Il 15/06/2014 16:24, Jan Kiszka ha scritto: >> +++ b/x86/vmx_tests.c >> @@ -820,8 +820,8 @@ static int iobmp_exit_handler() >> #define INSN_ALWAYS_TRAP 2 >> #define INSN_NEVER_TRAP 3 >> >> -#define FIELD_EXIT_QUAL 0 >> -#define FIELD_INSN_INFO 1 >> +#define FIELD_EXIT_QUAL 0x1 >> +#define FIELD_INSN_INFO 0x2 > > Small nit, using (1 << 0) and (1 << 1) would have reminded better this > lazy maintainer that these fields form a bitmask. :) Yes, see also the bug in KVM constants I posted recently. I'm inclined to apply such a pattern exclusively for now on, at least where this produces no inconsistencies with existing code. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
