Re: [PATCH v5 03/19] clean root dir of all x86-ness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 12/06/2014 12:40, Andrew Jones ha scritto:
> >+if [ -z "$testdir" -a \( "$arch" = "i386" -o "$arch" = "x86_64" \) ]; then
> >+    testdir=x86
> >+elif [ -z "$testdir" ]; then
> >+    testdir=$arch
> >+fi
> >+if [ ! -d $testdir ]; then
> >+    echo "$testdir does not exist!"
> >+    exit 1
> >+fi
> >+if [ -f $testdir/run ]; then
> >+    ln -fs $testdir/run $testdir-run
> >+fi
>
> Why is --test-dir useful?  Can you just use --arch instead?
testdir is not always the same as arch, e.g. arch=x86_64, testdir=x86,
and setting --arch x86 would lose useful information. We wouldn't know
if arch is supposed to be i386 or x86_64. The same argument will apply
to arch=arm vs. arch=aarch64.


Yes, testdir is useful indeed.  But what is the usecase for --test-dir?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux