On Mon, Feb 02, 2009 at 04:04:55PM +0200, Avi Kivity wrote: > Gleb Natapov wrote: >>> Right, I was thinking about >>> >>> if (irq >= 0 && irq < IOAPIC_NUM_PINS) { >>> >>> Should return MASKED if irq is outside the acceptable range? >>> >>> >> Is this ever can be false? Should we BUG() if irq is out of range? >> >> > > Yes, the number ultimately comes from userspace. > So may be -EINVAL should be returned to userspace? -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html