On 21/04/14 15:25, Oleg Nesterov wrote: > Hello. > > Completely untested and I know nothing about kvm ;) Please review. > > But use_mm() really looks misleading, and the usage of mm_users looks > "obviously wrong". I already sent this change while we were discussing > vmacache, but it was ignored. Since then kvm_async_page_present_sync() > was added into async_pf_execute() into async_pf_execute(), but it seems > to me that use_mm() is still unnecessary. > > Oleg. > > virt/kvm/async_pf.c | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) > I gave both patches some testing on s390, seems fine. I think patch2 really does fix a bug. So if Paolo, Marcelo, Gleb agree (maybe do a test on x86 for async_pf) both patches are good to go. Given that somebody tests this on x86: Acked-by: Christian Borntraeger <borntraeger@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
