Hi Marc,
> + if (migration_active && hugetlb) {
> + pmd_t *pmd;
> + pfn += (fault_ipa >> PAGE_SHIFT) &
> + (PTRS_PER_PMD-1);
MZ> Shouldn't that be "pfn += pte_index(fault_addr);"?
I'll change much cleaner.
> }
>
> + if (writable)
MZ> Shouldn't that be done only when migration is active?
Convention in other architectures is call it anytime page is dirty, the function
checks if dirty map is allocated if not it returns.
> + mark_page_dirty(kvm, gfn);
>
> out_unlock:
> spin_unlock(&kvm->mmu_lock);
--
Jazz is not dead. It just smells funny.
ÿ淸º{.nÇ+돴윯돪†+%듚ÿ깁負¥Šwÿº{.nÇ+돴ㅎoâ왲^n‡r⊆¦zË곷h솳鈺Ú&｛àz요z받쀺+€Ê+zf＂·hš닱~넮녬iÿÿï곴ÿ묎çz_溫æj:+v돣þ)山øm
