Re: [PULL 3/4] KVM: s390: Fix possible memory leak in SIGP functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/03/14 15:02, Paolo Bonzini wrote:
> Il 25/03/2014 14:35, Christian Borntraeger ha scritto:
>> From: Thomas Huth <thuth@xxxxxxxxxxxxxxxxxx>
>>
>> When kvm_get_vcpu() returned NULL for the destination CPU in
>> __sigp_emergency() or __sigp_external_call(), the memory for the
>> "inti" structure was not released anymore. This patch fixes this
>> issue by moving the check for !dst_vcpu before the kzalloc() call.
>>
>> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxxxxxxxxxx>
>> Reviewed-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> 
> Should patch 2 and this one have a Cc: stable?

This bug is not yet in 3.14-rc
It is only in kvm/next via commit  1ee0bc559dc34fe36a29494faf7b7c91533bd31c ( KVM: s390: get rid of local_int array)
So no need for stable.
patch 2 just reduces the memory usage from 64 bytes to 8 bytes.
Dont think we should use the stable folks for that.

Christian

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux