Re: [PATCH v3 1/3] KVM: nVMX: Rework interception of IRQs and NMIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 07/03/2014 19:26, Jan Kiszka ha scritto:
> Reading through my code again, I'm now wondering why I added
> check_nested_events to both inject_pending_event and vcpu_enter_guest.
> The former seems redundant, only vcpu_enter_guest calls
> inject_pending_event. I guess I forgot a cleanup here.
Nah, it's not redundant, we need to check for potential L2->L2 switches
*before* trying deliver events to L2.

Yeah, and after the call in inject_pending_event you can similarly have an "else if" since vmx_nmi/interrupt_allowed will check nested_run_pending and never return true.

But think I can (and probably
should) get rid of the second test in vcpu_enter_guest.

If so inject_pending_event would return true to request an immediate exit, right?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux