Re: [PATCH] virtio_net: Fix MAX_PACKET_LEN to support 802.1Q VLANs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2009-01-20 at 09:48 -0700, Alex Williamson wrote:

> 802.1Q expanded the maximum ethernet frame size by 4 bytes for the
> VLAN tag.  We're not taking this into account in virtio_net, which
> means the buffers we provide to the backend in the virtqueue RX ring
> aren't big enough to hold a full MTU VLAN packet.  For QEMU/KVM,
> this results in the backend exiting with a packet truncation error.
> 
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>

Acked-by: Mark McLoughlin <markmc@xxxxxxxxxx>

Note 1: this only matters if the guest isn't using mergeable receive
buffers or GSO

Note 2: IMHO, this should go in 2.6.29 and stable

Cheers,
Mark.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux