Alexey Kardashevskiy <aik@xxxxxxxxx> writes:
> On 07/01/2022 07:03, Fabiano Rosas wrote:
>> If MMIO emulation fails we don't want to crash the whole guest by
>> returning to userspace.
>>
>> The original commit bbf45ba57eae ("KVM: ppc: PowerPC 440 KVM
>> implementation") added a todo:
>>
>> /* XXX Deliver Program interrupt to guest. */
>>
>> and later the commit d69614a295ae ("KVM: PPC: Separate loadstore
>> emulation from priv emulation") added the Program interrupt injection
>> but in another file, so I'm assuming it was missed that this block
>> needed to be altered.
>>
>> Signed-off-by: Fabiano Rosas <farosas@xxxxxxxxxxxxx>
>
>
> Looks right.
> Reviewed-by: Alexey Kardashevskiy <aik@xxxxxxxxx>
>
> but this means if I want to keep debugging those kvm selftests in
> comfort, I'll have to have some exception handlers in the vm as
> otherwise the failing $pc is lost after this change :)
Yes! But that will be a problem for any test. These kinds of issues is
why I wanted a trial period before sending the test infrastructure
upstream. Maybe we don't need exception handlers, but just a way to
force the test to crash if it tries to fetch from 0x700.
