Re: [PATCH v1 4/4] KVM: stats: Add halt polling related histogram stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 28, 2021 at 5:45 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 06/07/21 20:03, Jing Zhang wrote:
> > +             kvm_stats_log_hist_update(
> > +                             vc->runner->stat.generic.halt_wait_hist,
> > +                             LOGHIST_SIZE_LARGE,
> > +                             ktime_to_ns(cur) - ktime_to_ns(start_wait));
>
> Instead of passing the size to the function, perhaps you can wrap it
> with a macro
>
> #define KVM_STATS_LOG_HIST_UPDATE(array, value) \
>      kvm_stats_log_hist_update(array, ARRAY_SIZE(array), value)
That's nice! Will do that.
>
> Paolo
>
Thanks,
Jing



[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux