"Pratik R. Sampat" <psampat@xxxxxxxxxxxxx> writes: Hi, I have some general comments and questions, mostly trying to understand design of the hcall and use cases of the sysfs data: > Adds a generic interface to represent the energy and frequency related > PAPR attributes on the system using the new H_CALL > "H_GET_ENERGY_SCALE_INFO". > > H_GET_EM_PARMS H_CALL was previously responsible for exporting this > information in the lparcfg, however the H_GET_EM_PARMS H_CALL > will be deprecated P10 onwards. > > The H_GET_ENERGY_SCALE_INFO H_CALL is of the following call format: > hcall( > uint64 H_GET_ENERGY_SCALE_INFO, // Get energy scale info > uint64 flags, // Per the flag request > uint64 firstAttributeId,// The attribute id > uint64 bufferAddress, // The logical address of the output buffer Instead of logical address, guest address or guest physical address would be more precise. > uint64 bufferSize // The size in bytes of the output buffer > ); > > This H_CALL can query either all the attributes at once with > firstAttributeId = 0, flags = 0 as well as query only one attribute > at a time with firstAttributeId = id > > The output buffer consists of the following > 1. number of attributes - 8 bytes > 2. array offset to the data location - 8 bytes The offset is from the start of the buffer, isn't it? So not the array offset. > 3. version info - 1 byte > 4. A data array of size num attributes, which contains the following: > a. attribute ID - 8 bytes > b. attribute value in number - 8 bytes > c. attribute name in string - 64 bytes > d. attribute value in string - 64 bytes Is this new hypercall already present in the spec? These seem a bit underspecified to me. > > The new H_CALL exports information in direct string value format, hence > a new interface has been introduced in /sys/firmware/papr to export Hm.. Maybe this should be something less generic than "papr"? > this information to userspace in an extensible pass-through format. > The H_CALL returns the name, numeric value and string value. As string > values are in human readable format, therefore if the string value > exists then that is given precedence over the numeric value. So the hypervisor could simply not send the string representation? How will the userspace tell the difference since they are reading everything from a file? Overall I'd say we should give the data in a more structured way and let the user-facing tool do the formatting and presentation. > > The format of exposing the sysfs information is as follows: > /sys/firmware/papr/ > |-- attr_0_name > |-- attr_0_val > |-- attr_1_name > |-- attr_1_val > ... How do we keep a stable interface with userspace? Say the hypervisor decides to add or remove attributes, change their order, string representation, etc? It will inform us via the version field, but that is lost when we output this to sysfs. I get that if the userspace just iterate over the contents of the directory then nothing breaks, but there is not much else it could do it seems. > > The energy information that is exported is useful for userspace tools > such as powerpc-utils. Currently these tools infer the > "power_mode_data" value in the lparcfg, which in turn is obtained from > the to be deprecated H_GET_EM_PARMS H_CALL. > On future platforms, such userspace utilities will have to look at the > data returned from the new H_CALL being populated in this new sysfs > interface and report this information directly without the need of > interpretation. > > Signed-off-by: Pratik R. Sampat <psampat@xxxxxxxxxxxxx>
