Hi Nicholas, I love your patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/KVM-PPC-Book3S-C-ify-the-P9-entry-exit-code/20210401-232743 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc64-randconfig-s032-20210402 (attached as .config) compiler: powerpc64le-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-279-g6d5d9b42-dirty # https://github.com/0day-ci/linux/commit/53519e6ae0f84e2742b886a08598648b424e6f08 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicholas-Piggin/KVM-PPC-Book3S-C-ify-the-P9-entry-exit-code/20210401-232743 git checkout 53519e6ae0f84e2742b886a08598648b424e6f08 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> sparse warnings: (new ones prefixed by >>) arch/powerpc/kvm/book3s_hv_builtin.c:417:41: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] *out_xirr @@ got restricted __be32 * @@ arch/powerpc/kvm/book3s_hv_builtin.c:417:41: sparse: expected unsigned int [usertype] *out_xirr arch/powerpc/kvm/book3s_hv_builtin.c:417:41: sparse: got restricted __be32 * >> arch/powerpc/kvm/book3s_hv_builtin.c:419:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [addressable] [usertype] xirr @@ got unsigned int @@ arch/powerpc/kvm/book3s_hv_builtin.c:419:22: sparse: expected restricted __be32 [addressable] [usertype] xirr arch/powerpc/kvm/book3s_hv_builtin.c:419:22: sparse: got unsigned int >> arch/powerpc/kvm/book3s_hv_builtin.c:450:41: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __be32 [addressable] [usertype] xirr @@ arch/powerpc/kvm/book3s_hv_builtin.c:450:41: sparse: expected unsigned int [usertype] val arch/powerpc/kvm/book3s_hv_builtin.c:450:41: sparse: got restricted __be32 [addressable] [usertype] xirr arch/powerpc/kvm/book3s_hv_builtin.c: note: in included file: arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __be64 arch/powerpc/include/asm/kvm_ppc.h:967:1: sparse: sparse: cast to restricted __le64 arch/powerpc/include/asm/kvm_ppc.h:963:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] srr0 @@ got restricted __be64 [usertype] @@ arch/powerpc/include/asm/kvm_ppc.h:963:1: sparse: expected unsigned long long [usertype] srr0 arch/powerpc/include/asm/kvm_ppc.h:963:1: sparse: got restricted __be64 [usertype] arch/powerpc/include/asm/kvm_ppc.h:963:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] srr0 @@ got restricted __le64 [usertype] @@ arch/powerpc/include/asm/kvm_ppc.h:963:1: sparse: expected unsigned long long [usertype] srr0 arch/powerpc/include/asm/kvm_ppc.h:963:1: sparse: got restricted __le64 [usertype] arch/powerpc/include/asm/kvm_ppc.h:964:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] srr1 @@ got restricted __be64 [usertype] @@ arch/powerpc/include/asm/kvm_ppc.h:964:1: sparse: expected unsigned long long [usertype] srr1 arch/powerpc/include/asm/kvm_ppc.h:964:1: sparse: got restricted __be64 [usertype] arch/powerpc/include/asm/kvm_ppc.h:964:1: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] srr1 @@ got restricted __le64 [usertype] @@ arch/powerpc/include/asm/kvm_ppc.h:964:1: sparse: expected unsigned long long [usertype] srr1 arch/powerpc/include/asm/kvm_ppc.h:964:1: sparse: got restricted __le64 [usertype] vim +419 arch/powerpc/kvm/book3s_hv_builtin.c f725758b899f11 Paul Mackerras 2016-11-18 395 f725758b899f11 Paul Mackerras 2016-11-18 396 static long kvmppc_read_one_intr(bool *again) 37f55d30df2eef Suresh Warrier 2016-08-19 397 { d381d7caf812f7 Benjamin Herrenschmidt 2017-04-05 398 void __iomem *xics_phys; 37f55d30df2eef Suresh Warrier 2016-08-19 399 u32 h_xirr; 37f55d30df2eef Suresh Warrier 2016-08-19 400 __be32 xirr; 37f55d30df2eef Suresh Warrier 2016-08-19 401 u32 xisr; 37f55d30df2eef Suresh Warrier 2016-08-19 402 u8 host_ipi; f725758b899f11 Paul Mackerras 2016-11-18 403 int64_t rc; 37f55d30df2eef Suresh Warrier 2016-08-19 404 5af50993850a48 Benjamin Herrenschmidt 2017-04-05 405 if (xive_enabled()) 5af50993850a48 Benjamin Herrenschmidt 2017-04-05 406 return 1; 5af50993850a48 Benjamin Herrenschmidt 2017-04-05 407 37f55d30df2eef Suresh Warrier 2016-08-19 408 /* see if a host IPI is pending */ 37f55d30df2eef Suresh Warrier 2016-08-19 409 host_ipi = local_paca->kvm_hstate.host_ipi; 37f55d30df2eef Suresh Warrier 2016-08-19 410 if (host_ipi) 37f55d30df2eef Suresh Warrier 2016-08-19 411 return 1; 37f55d30df2eef Suresh Warrier 2016-08-19 412 37f55d30df2eef Suresh Warrier 2016-08-19 413 /* Now read the interrupt from the ICP */ 37f55d30df2eef Suresh Warrier 2016-08-19 414 xics_phys = local_paca->kvm_hstate.xics_phys; 53af3ba2e8195f Paul Mackerras 2017-01-30 415 rc = 0; ab9bad0ead9ab1 Benjamin Herrenschmidt 2017-02-07 416 if (!xics_phys) 53af3ba2e8195f Paul Mackerras 2017-01-30 417 rc = opal_int_get_xirr(&xirr, false); 53af3ba2e8195f Paul Mackerras 2017-01-30 418 else d381d7caf812f7 Benjamin Herrenschmidt 2017-04-05 @419 xirr = __raw_rm_readl(xics_phys + XICS_XIRR); f725758b899f11 Paul Mackerras 2016-11-18 420 if (rc < 0) 37f55d30df2eef Suresh Warrier 2016-08-19 421 return 1; 37f55d30df2eef Suresh Warrier 2016-08-19 422 37f55d30df2eef Suresh Warrier 2016-08-19 423 /* 37f55d30df2eef Suresh Warrier 2016-08-19 424 * Save XIRR for later. Since we get control in reverse endian 37f55d30df2eef Suresh Warrier 2016-08-19 425 * on LE systems, save it byte reversed and fetch it back in 37f55d30df2eef Suresh Warrier 2016-08-19 426 * host endian. Note that xirr is the value read from the 37f55d30df2eef Suresh Warrier 2016-08-19 427 * XIRR register, while h_xirr is the host endian version. 37f55d30df2eef Suresh Warrier 2016-08-19 428 */ 37f55d30df2eef Suresh Warrier 2016-08-19 429 h_xirr = be32_to_cpu(xirr); 37f55d30df2eef Suresh Warrier 2016-08-19 430 local_paca->kvm_hstate.saved_xirr = h_xirr; 37f55d30df2eef Suresh Warrier 2016-08-19 431 xisr = h_xirr & 0xffffff; 37f55d30df2eef Suresh Warrier 2016-08-19 432 /* 37f55d30df2eef Suresh Warrier 2016-08-19 433 * Ensure that the store/load complete to guarantee all side 37f55d30df2eef Suresh Warrier 2016-08-19 434 * effects of loading from XIRR has completed 37f55d30df2eef Suresh Warrier 2016-08-19 435 */ 37f55d30df2eef Suresh Warrier 2016-08-19 436 smp_mb(); 37f55d30df2eef Suresh Warrier 2016-08-19 437 37f55d30df2eef Suresh Warrier 2016-08-19 438 /* if nothing pending in the ICP */ 37f55d30df2eef Suresh Warrier 2016-08-19 439 if (!xisr) 37f55d30df2eef Suresh Warrier 2016-08-19 440 return 0; 37f55d30df2eef Suresh Warrier 2016-08-19 441 37f55d30df2eef Suresh Warrier 2016-08-19 442 /* We found something in the ICP... 37f55d30df2eef Suresh Warrier 2016-08-19 443 * 37f55d30df2eef Suresh Warrier 2016-08-19 444 * If it is an IPI, clear the MFRR and EOI it. 37f55d30df2eef Suresh Warrier 2016-08-19 445 */ 37f55d30df2eef Suresh Warrier 2016-08-19 446 if (xisr == XICS_IPI) { 53af3ba2e8195f Paul Mackerras 2017-01-30 447 rc = 0; 53519e6ae0f84e Nicholas Piggin 2021-04-02 448 if (xics_phys) { d381d7caf812f7 Benjamin Herrenschmidt 2017-04-05 449 __raw_rm_writeb(0xff, xics_phys + XICS_MFRR); d381d7caf812f7 Benjamin Herrenschmidt 2017-04-05 @450 __raw_rm_writel(xirr, xics_phys + XICS_XIRR); f725758b899f11 Paul Mackerras 2016-11-18 451 } else { ab9bad0ead9ab1 Benjamin Herrenschmidt 2017-02-07 452 opal_int_set_mfrr(hard_smp_processor_id(), 0xff); ab9bad0ead9ab1 Benjamin Herrenschmidt 2017-02-07 453 rc = opal_int_eoi(h_xirr); 53af3ba2e8195f Paul Mackerras 2017-01-30 454 } f725758b899f11 Paul Mackerras 2016-11-18 455 /* If rc > 0, there is another interrupt pending */ f725758b899f11 Paul Mackerras 2016-11-18 456 *again = rc > 0; f725758b899f11 Paul Mackerras 2016-11-18 457 37f55d30df2eef Suresh Warrier 2016-08-19 458 /* 37f55d30df2eef Suresh Warrier 2016-08-19 459 * Need to ensure side effects of above stores 37f55d30df2eef Suresh Warrier 2016-08-19 460 * complete before proceeding. 37f55d30df2eef Suresh Warrier 2016-08-19 461 */ 37f55d30df2eef Suresh Warrier 2016-08-19 462 smp_mb(); 37f55d30df2eef Suresh Warrier 2016-08-19 463 37f55d30df2eef Suresh Warrier 2016-08-19 464 /* 37f55d30df2eef Suresh Warrier 2016-08-19 465 * We need to re-check host IPI now in case it got set in the 37f55d30df2eef Suresh Warrier 2016-08-19 466 * meantime. If it's clear, we bounce the interrupt to the 37f55d30df2eef Suresh Warrier 2016-08-19 467 * guest 37f55d30df2eef Suresh Warrier 2016-08-19 468 */ 37f55d30df2eef Suresh Warrier 2016-08-19 469 host_ipi = local_paca->kvm_hstate.host_ipi; 37f55d30df2eef Suresh Warrier 2016-08-19 470 if (unlikely(host_ipi != 0)) { 37f55d30df2eef Suresh Warrier 2016-08-19 471 /* We raced with the host, 37f55d30df2eef Suresh Warrier 2016-08-19 472 * we need to resend that IPI, bummer 37f55d30df2eef Suresh Warrier 2016-08-19 473 */ 53519e6ae0f84e Nicholas Piggin 2021-04-02 474 if (xics_phys) d381d7caf812f7 Benjamin Herrenschmidt 2017-04-05 475 __raw_rm_writeb(IPI_PRIORITY, d381d7caf812f7 Benjamin Herrenschmidt 2017-04-05 476 xics_phys + XICS_MFRR); f725758b899f11 Paul Mackerras 2016-11-18 477 else ab9bad0ead9ab1 Benjamin Herrenschmidt 2017-02-07 478 opal_int_set_mfrr(hard_smp_processor_id(), f725758b899f11 Paul Mackerras 2016-11-18 479 IPI_PRIORITY); 37f55d30df2eef Suresh Warrier 2016-08-19 480 /* Let side effects complete */ 37f55d30df2eef Suresh Warrier 2016-08-19 481 smp_mb(); 37f55d30df2eef Suresh Warrier 2016-08-19 482 return 1; 37f55d30df2eef Suresh Warrier 2016-08-19 483 } 37f55d30df2eef Suresh Warrier 2016-08-19 484 37f55d30df2eef Suresh Warrier 2016-08-19 485 /* OK, it's an IPI for us */ 37f55d30df2eef Suresh Warrier 2016-08-19 486 local_paca->kvm_hstate.saved_xirr = 0; 37f55d30df2eef Suresh Warrier 2016-08-19 487 return -1; 37f55d30df2eef Suresh Warrier 2016-08-19 488 } 37f55d30df2eef Suresh Warrier 2016-08-19 489 f725758b899f11 Paul Mackerras 2016-11-18 490 return kvmppc_check_passthru(xisr, xirr, again); 37f55d30df2eef Suresh Warrier 2016-08-19 491 } 5af50993850a48 Benjamin Herrenschmidt 2017-04-05 492 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
