Thanks for looking into this patch, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> writes: <snip> >> H_SCM_HEALTH specifications is already documented in linux kernel >> documentation at >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst > > Putting a reference to that in the commit message would be a good idea. > Yes, its already part of v1 patch description as reference [1]. <snip> >> > >> > Having access to the excerpts from the PAPR addendum that describes >> > this hcall would _really_ help in reviewing. >> > >> The kernel documentation for H_SCM_HEALTH mentioned above captures most >> if not all parts of the PAPR addendum for this hcall. I believe it >> contains enough information to review the patch. If you still need more >> info than please let me know. > > We've missed the qemu-6.0 cutoff, so this will be 6.1 material. I'll > await v2 for further review. > Agree. Will send a v2 today incorporating current review comments. -- Cheers ~ Vaibhav
