On Fri, Mar 12, 2021 at 07:38:46PM +1100, Alistair Popple wrote: > The behaviour of try_to_unmap_one() is difficult to follow because it > performs different operations based on a fairly large set of flags used > in different combinations. > > TTU_MUNLOCK is one such flag. However it is exclusively used by > try_to_munlock() which specifies no other flags. Therefore rather than > overload try_to_unmap_one() with unrelated behaviour split this out into > it's own function and remove the flag. > > Signed-off-by: Alistair Popple <apopple@xxxxxxxxxx> > Reviewed-by: Ralph Campbell <rcampbell@xxxxxxxxxx> > > --- > > Christoph - I didn't add your Reviewed-by from v3 because removal of the > extra VM_LOCKED check in v4 changed things slightly. Let me know if > you're still ok for me to add it. Thanks. Still looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
