On 9/19/20 3:29 AM, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx> Reviewed-by: Cédric Le Goater <clg@xxxxxxxx> > --- > v2: based on linux-next(20200917), and can be applied to > mainline cleanly now. > > arch/powerpc/kvm/book3s_xive_native.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_xive_native.c b/arch/powerpc/kvm/book3s_xive_native.c > index bdea91df1..d0c2db0e0 100644 > --- a/arch/powerpc/kvm/book3s_xive_native.c > +++ b/arch/powerpc/kvm/book3s_xive_native.c > @@ -1227,17 +1227,7 @@ static int xive_native_debug_show(struct seq_file *m, void *private) > return 0; > } > > -static int xive_native_debug_open(struct inode *inode, struct file *file) > -{ > - return single_open(file, xive_native_debug_show, inode->i_private); > -} > - > -static const struct file_operations xive_native_debug_fops = { > - .open = xive_native_debug_open, > - .read = seq_read, > - .llseek = seq_lseek, > - .release = single_release, > -}; > +DEFINE_SHOW_ATTRIBUTE(xive_native_debug); > > static void xive_native_debugfs_init(struct kvmppc_xive *xive) > { >