Excerpts from Michael Ellerman's message of June 30, 2020 11:31 am: > kernel test robot <lkp@xxxxxxxxx> writes: >> Hi Nicholas, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on powerpc/next] >> [also build test ERROR on scottwood/next v5.8-rc2 next-20200626] >> [cannot apply to kvm-ppc/kvm-ppc-next] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-pseries-IPI-doorbell-improvements/20200627-230544 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next >> config: powerpc-randconfig-c003-20200628 (attached as .config) >> compiler: powerpc64-linux-gcc (GCC) 9.3.0 > >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@xxxxxxxxx> >> >> All error/warnings (new ones prefixed by >>): >> >> In file included from arch/powerpc/kernel/asm-offsets.c:38: >> arch/powerpc/include/asm/dbell.h: In function 'doorbell_global_ipi': >>>> arch/powerpc/include/asm/dbell.h:114:12: error: implicit declaration of function 'get_hard_smp_processor_id'; did you mean 'raw_smp_processor_id'? [-Werror=implicit-function-declaration] >> 114 | u32 tag = get_hard_smp_processor_id(cpu); >> | ^~~~~~~~~~~~~~~~~~~~~~~~~ >> | raw_smp_processor_id >> arch/powerpc/include/asm/dbell.h: In function 'doorbell_try_core_ipi': >>>> arch/powerpc/include/asm/dbell.h:146:28: error: implicit declaration of function 'cpu_sibling_mask'; did you mean 'cpu_online_mask'? [-Werror=implicit-function-declaration] >> 146 | if (cpumask_test_cpu(cpu, cpu_sibling_mask(this_cpu))) { >> | ^~~~~~~~~~~~~~~~ >> | cpu_online_mask >>>> arch/powerpc/include/asm/dbell.h:146:28: warning: passing argument 2 of 'cpumask_test_cpu' makes pointer from integer without a cast [-Wint-conversion] >> 146 | if (cpumask_test_cpu(cpu, cpu_sibling_mask(this_cpu))) { >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > Seems like CONFIG_SMP=n is probably the root cause. > > You could try including asm/smp.h, but good chance that will lead to > header soup. Possibly. dbell.h shouldn't be included by much, but maybe it gets dragged in. > > Other option would be to wrap the whole lot in #ifdef CONFIG_SMP? Yeah that might be a better idea. I'll fix it up and repost if there's no strong objections to the KVM detection bit. Thanks, Nick
