Re: [PATCH] KVM: PPC: Book3S HV: Treat unrecognized TM instructions as illegal

[Gustavo Romero <gromero@xxxxxxxxxxxxxxxxxx>]

Hi Segher,

Thanks a lot for reviewing it.

On 02/13/2020 08:31 PM, Segher Boessenkool wrote:

<snip>

> > ---
> >   arch/powerpc/kvm/book3s_hv_tm.c | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_hv_tm.c b/arch/powerpc/kvm/book3s_hv_tm.c
> > index 0db937497169..d342a9e11298 100644
> > --- a/arch/powerpc/kvm/book3s_hv_tm.c
> > +++ b/arch/powerpc/kvm/book3s_hv_tm.c
> > @@ -3,6 +3,8 @@
> >    * Copyright 2017 Paul Mackerras, IBM Corp. <paulus@xxxxxxxxxxx>
> >    */
> >   
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > +
> >   #include <linux/kvm_host.h>
> >   
> >   #include <asm/kvm_ppc.h>
> > @@ -208,6 +210,8 @@ int kvmhv_p9_tm_emulation(struct kvm_vcpu *vcpu)
> >   	}
> >   
> >   	/* What should we do here? We didn't recognize the instruction */
> > -	WARN_ON_ONCE(1);
> > +	kvmppc_core_queue_program(vcpu, SRR1_PROGILL);
> > +	pr_warn_ratelimited("Unrecognized TM-related instruction %#x for emulation", instr);
> > +
> >   	return RESUME_GUEST;
> >   }
>
> Do we actually know it is TM-related here?  Otherwise, looks good to me :-)

Correct, I understand it's only TM-related here, so I don't expect anything else to hit 0x1500.


Best regards,
Gustavo