On Mon, Dec 16, 2019 at 03:19:23PM +1100, Alexey Kardashevskiy wrote: > H_PUT_TCE_INDIRECT allows packing up to 512 TCE updates into a single > hypercall; H_STUFF_TCE can clear lots in a single hypercall too. > > However, unlike H_STUFF_TCE (which writes the same TCE to all entries), > H_PUT_TCE_INDIRECT uses a 4K page with new TCEs. In a secure VM > environment this means sharing a secure VM page with a hypervisor which > we would rather avoid. > > This splits the FW_FEATURE_MULTITCE feature into FW_FEATURE_PUT_TCE_IND Can FW_FEATURE_PUT_TCE_IND be made FW_FEATURE_PUT_TCE_INDIRECT? It conveys the meaning a bit better than FW_FEATURE_PUT_TCE_IND. This patch is a good optimization. Reviewed-by: Ram Pai <linuxram@xxxxxxxxxx> Thanks, RP > -- snip.. > 2.17.1 -- Ram Pai