On Mon, May 20, 2019 at 10:56:58AM +1000, Nicholas Piggin wrote: > kvmppc_inject_interrupt does not implement LPCR[AIL]!=0 modes, which > can result in the guest receiving interrupts as if LPCR[AIL]=0 > contrary to the ISA. > > In practice, Linux guests cope with this deviation, but it should be > fixed. Comment below... > diff --git a/arch/powerpc/kvm/book3s_hv_builtin.c b/arch/powerpc/kvm/book3s_hv_builtin.c > index 5ae7f8359368..2453a085da86 100644 > --- a/arch/powerpc/kvm/book3s_hv_builtin.c > +++ b/arch/powerpc/kvm/book3s_hv_builtin.c > @@ -797,6 +797,20 @@ void kvmppc_inject_interrupt_hv(struct kvm_vcpu *vcpu, int vec, u64 srr1_flags) > new_msr |= msr & MSR_TS_MASK; > #endif > > +#ifdef CONFIG_PPC_BOOK3S_64 Why do we need this ifdef? This file doesn't get compiled when CONFIG_PPC_BOOK3S_64=n, right? Paul.
