On 13/05/2019 19:14, Fabiano Rosas wrote:
> Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx> writes:
>
>> For comparison both booke.c and e500_emulate.c set debug.arch.status = 0 for software
>> breakpoints, whereas both book3s_hv.c and book3s_pr.c do not. Given that emulate.c
>> contains shared code for handling software breakpoints, would the following simple
>> patch suffice?
>>
>>
>> diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
>> index 9f5b8c01c4e1..e77becaad5dd 100644
>> --- a/arch/powerpc/kvm/emulate.c
>> +++ b/arch/powerpc/kvm/emulate.c
>> @@ -282,6 +282,7 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct
>> kvm_vcpu *vcpu)
>> */
>> if (inst == KVMPPC_INST_SW_BREAKPOINT) {
>> run->exit_reason = KVM_EXIT_DEBUG;
>> + run->debug.arch.status = 0;
>> run->debug.arch.address = kvmppc_get_pc(vcpu);
>> emulated = EMULATE_EXIT_USER;
>> advance = 0;
>
> This looks reasonable to me.
Great, thanks for the review! I'm fairly busy for the next few days, but will send a
proper patch towards the end of the week.
ATB,
Mark.
