Re: [PATCH] KVM: PPC: Book3S: Allow XICS emulation to work in nested hosts using XIVE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on v5.0-rc4 next-20190212]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paul-Mackerras/KVM-PPC-Book3S-Allow-XICS-emulation-to-work-in-nested-hosts-using-XIVE/20190204-194230
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: powerpc-skiroot_defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/kernel/smp.c:44:
   arch/powerpc/include/asm/kvm_ppc.h: In function 'xics_on_xive':
>> arch/powerpc/include/asm/kvm_ppc.h:624:9: error: implicit declaration of function 'xive_enabled'; did you mean 'eeh_enabled'? [-Werror=implicit-function-declaration]
     return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
            ^~~~~~~~~~~~
            eeh_enabled
   cc1: all warnings being treated as errors

vim +624 arch/powerpc/include/asm/kvm_ppc.h

   620	
   621	#ifdef CONFIG_PPC_POWERNV
   622	static inline bool xics_on_xive(void)
   623	{
 > 624		return xive_enabled() && cpu_has_feature(CPU_FTR_HVMODE);
   625	}
   626	#else
   627	static inline bool xics_on_xive(void)
   628	{
   629		return false;
   630	}
   631	#endif
   632	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux