Re: [PATCH 02/13] KVM: PPC: Ultravisor: Include ultravisor header file.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 22, 2019 at 07:59:33AM -0800, Ram Pai wrote:
> This file contains the definitions of all ultracalls.

"will contain", perhaps?

> Signed-off-by: Ram Pai <linuxram@xxxxxxxxxx>
> ---
>  arch/powerpc/include/asm/ucall-api.h        |  5 +++++
>  arch/powerpc/include/uapi/asm/uapi_uvcall.h | 10 ++++++++++

This is the wrong place for these definitions.  The "u" in uapi stands
for "user", and this directory is for the definition of the API that
the kernel provides to userspace.  This file should just go in the
normal arch/powerpc/include/asm directory, and it shouldn't have
"uapi" in its name.

Paul.



[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux