On Mon, 7 May 2018 10:32:52 +1000 Paul Mackerras <paulus@xxxxxxxxxx> wrote: > On Sun, May 06, 2018 at 05:37:23PM +1000, Nicholas Piggin wrote: > > The current partition table unmap code clears the _PAGE_PRESENT bit > > out of the pte, which leaves pud_huge/pmd_huge true and does not > > clear pud_present/pmd_present. This can confuse subsequent page > > faults. > > I'm OK with the patch, but this sounds like we can have a pmd where > the hardware does not consider it to be a valid translation, but > pmd_huge() and pmd_present() are both true. That sounds like a > disaster waiting to happen elsewhere -- pmd_present() at least should > be fixed, and possible pmd_huge() also. I don't know that we can after this patch. I can't see where that would happen. If you mean you just want to test just PAGE_PRESENT just in case there are similar bugs, then sure I don't see a problem with that. Thanks, Nick -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html