Re: [PATCH 05/19] powerpc/chrp/setup: Add attribute unused and make some functions static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le 22/03/2018 à 21:19, Mathieu Malaterre a écrit :
Add gcc attribute unused to silence a warning.

These functions can all be static, make it so. Fix warnings treated as
errors with W=1:

   arch/powerpc/platforms/chrp/setup.c:97:6: error: no previous prototype for ‘chrp_show_cpuinfo’ [-Werror=missing-prototypes]
   arch/powerpc/platforms/chrp/setup.c:302:13: error: no previous prototype for ‘chrp_setup_arch’ [-Werror=missing-prototypes]
   arch/powerpc/platforms/chrp/setup.c:385:16: error: variable ‘idu_size’ set but not used [-Werror=unused-but-set-variable]
   arch/powerpc/platforms/chrp/setup.c:526:13: error: no previous prototype for ‘chrp_init_IRQ’ [-Werror=missing-prototypes]
   arch/powerpc/platforms/chrp/setup.c:559:1: error: no previous prototype for ‘chrp_init2’ [-Werror=missing-prototypes]

Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
---
  arch/powerpc/platforms/chrp/setup.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c
index 481ed133e04b..85df479fd631 100644
--- a/arch/powerpc/platforms/chrp/setup.c
+++ b/arch/powerpc/platforms/chrp/setup.c
@@ -94,7 +94,7 @@ static const char *chrp_names[] = {
  	"Total Impact Briq"
  };
-void chrp_show_cpuinfo(struct seq_file *m)
+static void chrp_show_cpuinfo(struct seq_file *m)
  {
  	int i, sdramen;
  	unsigned int t;
@@ -299,7 +299,7 @@ static __init void chrp_init(void)
  	of_node_put(node);
  }
-void __init chrp_setup_arch(void)
+static void __init chrp_setup_arch(void)
  {
  	struct device_node *root = of_find_node_by_path("/");
  	const char *machine = NULL;
@@ -382,7 +382,7 @@ static void __init chrp_find_openpic(void)
  {
  	struct device_node *np, *root;
  	int len, i, j;
-	int isu_size, idu_size;
+	int isu_size, idu_size __maybe_unused;

idu_size is never used, you could remove it completely

Christophe

  	const unsigned int *iranges, *opprop = NULL;
  	int oplen = 0;
  	unsigned long opaddr;
@@ -523,7 +523,7 @@ static void __init chrp_find_8259(void)
  	}
  }
-void __init chrp_init_IRQ(void)
+static void __init chrp_init_IRQ(void)
  {
  #if defined(CONFIG_VT) && defined(CONFIG_INPUT_ADBHID) && defined(CONFIG_XMON)
  	struct device_node *kbd;
@@ -555,7 +555,7 @@ void __init chrp_init_IRQ(void)
  #endif
  }
-void __init
+static void __init
  chrp_init2(void)
  {
  #ifdef CONFIG_NVRAM


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux