On Fri, 16 Mar 2018 16:26:33 +1100
Michael Neuling <mikey@xxxxxxxxxxx> wrote:
> On Fri, 2018-03-16 at 13:43 +1000, Nicholas Piggin wrote:
> > On Fri, 16 Mar 2018 13:54:56 +1100
> > Michael Neuling <mikey@xxxxxxxxxxx> wrote:
> >
> >
> > > diff --git a/arch/powerpc/kernel/dt_cpu_ftrs.c
> > > b/arch/powerpc/kernel/dt_cpu_ftrs.c
> > > index 945e2c29ad..dfb77b43f1 100644
> > > --- a/arch/powerpc/kernel/dt_cpu_ftrs.c
> > > +++ b/arch/powerpc/kernel/dt_cpu_ftrs.c
> > > @@ -62,7 +62,6 @@ struct dt_cpu_feature {
> > > CPU_FTR_COHERENT_ICACHE | \
> > > CPU_FTR_STCX_CHECKS_ADDRESS |\
> > > CPU_FTR_POPCNTB | CPU_FTR_POPCNTD | \
> > > - CPU_FTR_DAWR | \
> > > CPU_FTR_ARCH_206 |\
> > > CPU_FTR_ARCH_207S)
> >
> > This may be better to clear in cpufeatures_cpu_quirks().
>
> OK, I wasn't sure about this bit... thanks for catching. I'll move to there.
>
> > This is supposed to work on POWER8 as well.
>
> Arrh, yeah.
We *could* move DAWR out of the base feature set. Firmare is not
actually being released for POWER8 in production... Then we can add
a new dt property for DAWR. Existing POWER9 firmware would do the
right thing for new kernels.
I mean DAWR is fairly fundamental so making it a quirk isn't unreasonable
either, just means we have to patch kernels with PVRs.
Thanks,
Nick
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
