Paul Mackerras <paulus@xxxxxxxxxx> writes: > On Fri, Aug 25, 2017 at 02:30:34PM +1000, Nicholas Piggin wrote: >> diff --git a/arch/powerpc/kernel/idle_book3s.S b/arch/powerpc/kernel/idle_book3s.S >> index 4924647d964d..14e97f442167 100644 >> --- a/arch/powerpc/kernel/idle_book3s.S >> +++ b/arch/powerpc/kernel/idle_book3s.S >> @@ -205,6 +205,19 @@ pnv_powersave_common: >> mtmsrd r7,0 >> bctr >> >> +/* >> + * This is the sequence required to execute idle instructions, as >> + * specified in ISA v2.07. MSR[IR] and MSR[DR] must be 0. >> + */ >> +#define ARCH207_IDLE_STATE_ENTER_SEQ_NORET(IDLE_INST) \ > > We had to do this sequence on POWER7 also, which is architecture > v2.06. Thus the comments and the naming (ARCH207_*) are a bit > misleading here. The actual code change looks OK. I'll just drop the name change, I don't think it's crucial. That makes P9 the special case. We can come up with a better name or something in future. Unless Nick objects? cheers -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
