Re: [PATCH] KVM: PPC: Fix emulated MMIO sign-extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 05, 2016 at 04:17:10PM +1000, Paul Mackerras wrote:
> When the guest does a sign-extending load instruction (such as lha
> or lwa) to an emulated MMIO location, it results in a call to
> kvmppc_handle_loads() in the host.  That function sets the
> vcpu->arch.mmio_sign_extend flag and calls kvmppc_handle_load()
> to do the rest of the work.  However, kvmppc_handle_load() sets
> the mmio_sign_extend flag to 0 unconditionally, so the sign
> extension never gets done.
> 
> To fix this, we rename kvmppc_handle_load to __kvmppc_handle_load
> and add an explicit parameter to indicate whether sign extension
> is required.  kvmppc_handle_load() and kvmppc_handle_loads() then
> become 1-line functions that just call __kvmppc_handle_load()
> with the extra parameter.
> 
> Reported-by: Bin Lu <lblulb@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Paul Mackerras <paulus@xxxxxxxxxx>

Applied to my kvm-ppc-next branch.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux