Re: [kvm-unit-test PATCH v2] powerpc: Add emulator test for the lswi instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 20/04/2016 11:24, Thomas Huth wrote:
>>> +		      ".long 0x7fe154aa\n"       /* lswi r31, r1, 10 */
>>
>> Perhaps you can add a comment explaining why you are using a .long
>> instead of the mnemonic?
>
> The compiler is smart enough to detect that r1 is in the range of
> registers that get clobbered, and thus rejects that mnemonic. You
> quickly notice that when replacing the .long with the mnemonic, so I'm
> not sure whether it's worth to add a verbose comment here... Paolo, what
> do you prefer?

The assembler does this, not the compiler.  Is this a valid operation at
all, or is it undefined?  (aka, what does it do on real hardware)? O_o

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux