On Wed, Feb 10, 2016 at 03:27:09PM +0100, Paolo Bonzini wrote: > > > On 08/02/2016 19:53, Andrew Jones wrote: > > It's been a loooong time since I posted v1 of this series, but thanks > > to Thomas' poking, and even volunteering to help move v2 along, I've > > finally picked it back up. > > > > v2: > > Besides rebasing on latest master, v2 addresses all of David's comments > > - assembler cleanup > > - jump into the RTAS blob we get from DT, instead of reproducing it > > - don't store the RTAS root node, always hunt it down > > > > v2 didn't address debug-exit, and we still need a solution for that. > > Plugging chr-testdev into an spapr vty is probably what we should > > investigate first (as was suggested by Alex Graf under the v1 review). > > For this v2 I just kept the hack from v1, but simplified it and > > explicitly call it out as the hack that it is. > > > > Additional known issues: > > Latest F22 cross-compiler (gcc5 based) doesn't generate working > > code with this series. I didn't try to debug. The 4.9 based compiler > > I initially used on v1 works, so I reverted to that one. > > > > Testing: > > I only tested with qemu-system-ppc64 (latest) on x86_64 so far. I'll > > try to get a machine to test with real hardware (and KVM) unless > > someone (hi Thomas :-) beats me to it. > > > > Standard cover-letter summary: > > This series brings basic setup; starts a test's C entry point, main(), > > and printf, exit, and malloc work. Three more series should follow this > > one which must bring; vector support, mmu support, and smp support, at > > which point I believe the framework could just evolve with the creation > > of unit tests. > > > > Patches also available here > > https://github.com/rhdrjones/kvm-unit-tests/commits/ppc64/initial-drop-v2 > > The only request is to not include zero-size files; just leave them out > and add them as necessary. Yeah, upon reflection of that idea, it was dumb. I'll not do that. > > Otherwise it's nice. :) Thanks! So, how should we proceed? I propose to 1) Wait for some more reviews (some r-b's would be nice to add) 2) I'll remove the zero-size files and fix anything else brought up, then post a v3. Then 3) Q: Should we wait until the debug-exit hack has been replaced with something better? Or could we commit it as a starter (I believe it may already even be a useful framework for hypercall testing. Something Thomas wants to use it for now.) drew > > Paolo > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
