On Mon, 2014-05-19 at 14:55 +0200, Alexander Graf wrote: > On 14.05.14 06:12, Gavin Shan wrote: > > Originally, syscall ppc_rtas() can be used to invoke RTAS call from > > user space. Utility "errinjct" is using it to inject various errors > > to the system for testing purpose. The patch intends to extend the > > syscall to support both pSeries and PowerNV platform. With that, > > RTAS and OPAL call can be invoked from user space. In turn, utility > > "errinjct" can be supported on pSeries and PowerNV platform at same > > time. > > > > The original syscall handler ppc_rtas() is renamed to ppc_firmware(), > > which calls ppc_call_rtas() or ppc_call_opal() depending on the > > running platform. The data transported between userland and kerenl is > > Please fix your spelling of kernel. > > > by "struct rtas_args". It's platform specific on how to use the data. > > > > Signed-off-by: Mike Qiu <qiudayu@xxxxxxxxxxxxxxxxxx> > > Signed-off-by: Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx> > > I think the basic idea to maintain the same interface between PAPR and > OPAL to user space is sound, but this is really Ben's call. Yeah that worries me a bit, RTAS and OPAL are completely different beasts. We can keep that error injection separate from the rest of the EEH enablement for now. I'll look at it when I get a chance. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html