Re: [PATCH 6/6] KVM: PPC: Book3S PR: Expose TM registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17.05.14 08:20, Paul Mackerras wrote:
On Tue, Apr 29, 2014 at 06:17:42PM +0200, Alexander Graf wrote:
POWER8 introduces transactional memory which brings along a number of new
registers and MSR bits.

Implementing all of those is a pretty big headache, so for now let's at least
emulate enough to make Linux's context switching code happy.
[snip]

-	if (!(vcpu->arch.fscr & (1ULL << fac))) {
+	/* We get TM interrupts only when EBB is disabled? Sigh. */
This comment doesn't make sense to me.  Not every reason code reported
in the high bits of FSCR corresponds directly to an enable bit in
FSCR.  In fact, of the 7 defined reason codes in POWER8, only three
correspond to an enable bit...

Is there any documentation on which relate to what?


Alex


+	if ((fac != FSCR_TM_LG) && !(vcpu->arch.fscr & (1ULL << fac))) {
so this should really check explicitly for TAR, EBB or DSCR.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux