On Tue, 2013-05-07 at 15:15 +0800, tiejun.chen wrote:
> Could we simplify this as follows:
>
> +#define hard_irq_disable() do { \
> + __hard_irq_disable(); \
> + if (get_paca()->soft_enabled) { \
> + trace_hardirqs_off(); \
> + get_paca()->soft_enabled = 0; \
> + } \
> + get_paca()->irq_happened |= PACA_IRQ_HARD_DIS; \
> +} while(0)
I'd rather not. When lockdep is not enabled trace_hardirqs_off() is a
nop and thus we have no conditional at all which is arguably better...
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
