Michael, On Tue, Oct 16, 2012 at 11:15:50AM +1100, Michael Ellerman wrote: > In the Book3s HV code, kvmppc_run_core() has logic to grab the secondary > threads of the physical core. > > If for some reason a thread is stuck, kvmppc_grab_hwthread() can fail, > but currently we ignore the failure and continue into the guest. If the > stuck thread is in the kernel badness ensues. > > Instead we should check for failure and bail out. > > I've moved the grabbing prior to the startup of runnable threads, to simplify > the error case. AFAICS this is harmless, but I could be missing something > subtle. Thanks for looking at this - but in fact this is fixed by my patch entitled "KVM: PPC: Book3S HV: Fix some races in starting secondary threads" submitted back on August 28. Regards, Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
