On Aug 4, 2012, at 1:31 PM, Sethi Varun-B16395 wrote: > > >> -----Original Message----- >> From: Kumar Gala [mailto:galak@xxxxxxxxxxxxxxxxxxx] >> Sent: Friday, August 03, 2012 10:04 PM >> To: Sethi Varun-B16395 >> Cc: agraf@xxxxxxx; benh@xxxxxxxxxxxxxxxxxxx; linuxppc- >> dev@xxxxxxxxxxxxxxxx; kvm-ppc@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH 2/4] powerpc/booke: Merge the 32 bit e5500/e500mc cpu >> setup code. >> >> >> On Jul 9, 2012, at 7:58 AM, Varun Sethi wrote: >> >>> Merge the 32 bit cpu setup code for e500mc/e5500 and define the >> "cpu_restore" >>> routine (for e5500/e6500) only for the 64 bit case. The cpu_restore >>> routine is used in the 64 bit case for setting up the secondary cores. >>> >>> Signed-off-by: Varun Sethi <Varun.Sethi@xxxxxxxxxxxxx> >>> --- >>> arch/powerpc/kernel/cpu_setup_fsl_booke.S | 1 + >>> arch/powerpc/kernel/cputable.c | 4 ++++ >>> 2 files changed, 5 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/powerpc/kernel/cpu_setup_fsl_booke.S >>> b/arch/powerpc/kernel/cpu_setup_fsl_booke.S >>> index a55d028..5e87737 100644 >>> --- a/arch/powerpc/kernel/cpu_setup_fsl_booke.S >>> +++ b/arch/powerpc/kernel/cpu_setup_fsl_booke.S >>> @@ -75,6 +75,7 @@ _GLOBAL(__setup_cpu_e500v2) >>> mtlr r4 >>> blr >>> _GLOBAL(__setup_cpu_e500mc) >>> +_GLOBAL(__setup_cpu_e5500) >> >> This is a bit confusing, as we now have duplicated __setup_cpu_e5500() >> between the ppc32 and ppc64 cases. >> >> If you build this patch for corenet32_smp_defconfig it fails. > [Sethi Varun-B16395] I am able to build without any issue with the same config. > > -Varun If you build corenet32_smp_defconfig at commit: commit c5537ef2d672d2cf48d4e4ac754781c8db112843 Author: Varun Sethi <Varun.Sethi@xxxxxxxxxxxxx> Date: Mon Jul 9 18:28:21 2012 +0530 powerpc/booke: Merge the 32 bit e5500/e500mc cpu setup code. You get the following build error: arch/powerpc/kernel/cpu_setup_fsl_booke.S: Assembler messages: arch/powerpc/kernel/cpu_setup_fsl_booke.S:110: Error: symbol `__setup_cpu_e5500' is already defined - k-- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
