> -----Original Message----- > From: kvm-ppc-owner@xxxxxxxxxxxxxxx [mailto:kvm-ppc-owner@xxxxxxxxxxxxxxx] On Behalf Of Scott Wood > Sent: Monday, July 16, 2012 12:12 PM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; Alexander Graf; qemu-ppc@xxxxxxxxxx; kvm-ppc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] openpic: Added BRR1 register > > On 07/16/2012 12:09 PM, Bhushan Bharat-R65777 wrote: > > > > > >> -----Original Message----- > >> From: Wood Scott-B07421 > >> Sent: Monday, July 16, 2012 10:34 PM > >> To: Bhushan Bharat-R65777 > >> Cc: Alexander Graf; qemu-ppc@xxxxxxxxxx; kvm-ppc@xxxxxxxxxxxxxxx > >> Subject: Re: [PATCH] openpic: Added BRR1 register > >> > >> On 07/16/2012 11:21 AM, Bhushan Bharat-R65777 wrote: > >>>>> + case 0x00: /* BRR1 */ > >>>>> + retval = 0x00400200; > >>>> > >>>> Please unmagicify this one :) > >>> > >>> /* BRR1 ( Block revision register ) */ > >>> > >>> #define IPID 0x00400000 /* IP-block ID */ #define IPMJ 0x00000200 /* > >>> IP major number */ #define IPMN 0x00000200 /* IP minor number */ > >> > >> IPMN looks wrong. > > > > Opps : copy paste error here :) > > > > Btw, I am not aware of all MPIC IP versions, differences in them and what is the latest/best version > this emulated code supports. I drive this value from mpc8544 Reference Manual. > > > > I requested Alex to suggest the most updated version. > > QEMU does not have a complete implementation of any version of the FSL MPIC. So what revision numbers should we use? Stuart ��.n��������+%������w��{.n�����o��^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
