> -----Original Message----- > From: Wood Scott-B07421 > Sent: Tuesday, June 19, 2012 2:19 AM > To: Sethi Varun-B16395 > Cc: kvm-ppc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] KVM: PPC: bookehv64: Add support for std/ld > emulation. > > On 06/18/2012 03:42 PM, Varun Sethi wrote: > > Add support for std/ld emulation. > > > > Signed-off-by: Varun Sethi <Varun.Sethi@xxxxxxxxxxxxx> > > --- > > arch/powerpc/kvm/emulate.c | 14 ++++++++++++++ > > 1 files changed, 14 insertions(+), 0 deletions(-) > > > > diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c > > index f90e86d..a04543a 100644 > > --- a/arch/powerpc/kvm/emulate.c > > +++ b/arch/powerpc/kvm/emulate.c > > @@ -59,11 +59,13 @@ > > #define OP_31_XOP_STHBRX 918 > > > > #define OP_LWZ 32 > > +#define OP_LD 58 > > #define OP_LWZU 33 > > #define OP_LBZ 34 > > #define OP_LBZU 35 > > #define OP_STW 36 > > #define OP_STWU 37 > > +#define OP_STD 62 > > #define OP_STB 38 > > #define OP_STBU 39 > > #define OP_LHZ 40 > > What about STDU, STDX, LWA, etc? If you're going to add some 64-bit > load/store instructions, but not others of the same classes as are > implemented for 32-bit, at least leave a comment pointing out what's > missing. There would be a separate patch for supporting those instructions. I will a "TBD" comment in the code. -Varun ��.n��������+%������w��{.n�����o��^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�