Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/14/2011 06:00 PM, Benjamin Herrenschmidt wrote:
On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote:
       /* USB */
       if (usb_enabled) {

usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1);
+     if (spapr_has_graphics) {
+         usbdevice_create("keyboard");
+         usbdevice_create("mouse");

It is better to use usb_create() and pass it the usb bus directly as
this will make it easier to express this as composition down the road.

How do I do that ? usb_ohci_init_pci() doesn't appear to return
the USB bus....

Let's make it...  I'll send a patch.

Regards,

Anthony Liguori


Cheers,
Ben.




--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux