On Wed, 2011-12-14 at 11:34 +1100, Matt Evans wrote: > On 13/12/11 21:23, Sasha Levin wrote: > > On Tue, 2011-12-13 at 18:00 +1100, Matt Evans wrote: > >> The second patch is a small fix for generic virtio code (now that we have a > >> PPC build) which removes reliance on ioeventfds for PPC, which doesn't provide > >> them. > > > > Hm... ioeventfds are located in the generic code and should be available > > on all archs (it doesn't use any arch specific code at all afaik). > > > > Why don't they work on ppc? > > > > Well, there are two problems: you're right that it's generic code, but it's > configurable and CONFIG_HAVE_KVM_EVENTFD isn't set for PPC KVM (thus the ioctl > fails). That's probably off because ioevents won't work anyway-- the in-kernel > MMIO exit route isn't wired up to kvm_io_bus_read/write() yet. (It looks like > KVM_IRQFD will also fail, which virtio-pci /would/ use if I supported MSIs, > which I currently don't.) > > Yes, this can be fixed, but relying on it means that virtio on kvmtool/PPC won't > work on today's kernels. :( In that case, KVM_CAP_IOEVENTFD is simply not set, so we're better off checking the cap dynamically instead of having it defined statically in the makefile. I'll send a short patch that does that. -- Sasha. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
