> -----Original Message----- > From: Alexander Graf [mailto:agraf@xxxxxxx] > Sent: Monday, October 17, 2011 2:33 PM > To: Yoder Stuart-B08248 > Cc: kvm-ppc@xxxxxxxxxxxxxxx > Subject: Re: magic page API > > > Am 17.10.2011 um 18:54 schrieb Yoder Stuart-B08248 <B08248@xxxxxxxxxxxxx>: > > > The magic page hcall API and related data structure fields has the following: > > > > unsigned long magic_page_pa; /* phys addr to map the magic page to */ > > unsigned long magic_page_ea; /* effect. addr to map the magic > > page to */ > > > > Shouldn't the PA be 64-bits? Or some phys addr type. Not sure when > > the phys addr is needed but assuming 32-bits seems wrong. > > The PA is passed in a register, no? Hence the ulong. We should probably extend it, true. Well we've normally used 2 registers for passing these types of values. Maybe it doesn't matter in the end. I guess the question is-- is there any 32-bit guest with possibly > 32-bit physical addresses that would use the PA argument. Book3E does not use it so we really don't care. Stuart -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
