Re: [PATCH 1/5] KVM: PPC: booke: Fix int_pending calculation for MSR[EE] paravirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/02/2011 08:53 AM, Alexander Graf wrote:
> On 08/27/2011 01:31 AM, Scott Wood wrote:
>> int_pending was only being lowered if a bit in pending_exceptions
>> was cleared during exception delivery -- but for interrupts, we clear
>> it during IACK/TSR emulation.  This caused paravirt for enabling
>> MSR[EE] to be ineffective.
> 
> But that means that int_pending can still be 1 even though there is none
> pending as we don't get the call to deliver_interrupts when it gets
> lowered. Please create a common function to remove a bit from
> pending_exceptions and do the check there.

I can do that if you want, but kvmppc_core_deliver_interrupts() should
always get called before we return to the guest.  Dequeues that are
asynchronous to a guest exit should be very rare, and would be cured on
the first subsequent guest exit.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux