Re: [PATCH 1/5] KVM: PPC: e500: tlbsx: fix tlb0 esel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18.07.2011, at 23:43, Scott Wood wrote:

> On Mon, 18 Jul 2011 23:37:50 +0200
> Alexander Graf <agraf@xxxxxxx> wrote:
> 
>> I guess I'm merely not understanding why we have the non-way bits set in TLB0 entries, but not in TLB1 ones :). Do we pass in the real array index?
> 
> KVM internally uses the full TLB index (and unfortunately calls it esel) in
> some places, such as kvmppc_e500_tlb_index.  But we don't want to leak that
> to the guest.

That's what I figured. So can we guarantee that internally esel for TLB1 is always < TLB1_NUM_ENTRIES? If so, we don't need to mask it. If not, we should.


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux