On May 17, 2011, at 6:35 PM, Scott Wood wrote: > From: yu liu <yu.liu@xxxxxxxxxxxxx> > > giveup_spe() saves the SPE state which is protected by MSR[SPE]. > However, modifying SPEFSCR does not trap when MSR[SPE]=0. > And since SPEFSCR is already saved/restored in _switch(), > not all the callers want to save SPEFSCR again. > Thus, saving SPEFSCR should not belong to giveup_spe(). > > This patch moves SPEFSCR saving to flush_spe_to_thread(), > and cleans up the caller that needs to save SPEFSCR accordingly. > > Signed-off-by: Liu Yu <yu.liu@xxxxxxxxxxxxx> > Signed-off-by: Scott Wood <scottwood@xxxxxxxxxxxxx> > --- > This is a resending of http://patchwork.ozlabs.org/patch/88677/ > > Kumar, please ack to go via kvm. This is holding up the rest of the SPE > patches, which in turn are holding up the MMU patches due to both > touching the MSR update code. > > arch/powerpc/kernel/head_fsl_booke.S | 2 -- > arch/powerpc/kernel/process.c | 1 + > arch/powerpc/kernel/traps.c | 5 +---- > 3 files changed, 2 insertions(+), 6 deletions(-) Acked-by: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> [ Alex, let me know if you want this via my powerpc.git tree or your kvm tree ] - k-- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html