On 04.10.2010, at 07:22, Christian Ehrhardt wrote: > > On 10/01/2010 12:07 AM, Alexander Graf wrote: >> >> On 30.09.2010, at 21:28, Scott Wood wrote: >> >>> It is not legal to call mutex_lock() with interrupts disabled. >>> This will assert with debug checks enabled. >>> >>> If there's a real need to disable interrupts here, it could be done >>> after the mutex is acquired -- but I don't see why it's needed at all. >> >> Christian, IIRC this code is yours. Any comments? > > Yes, It should be save to drop the irq_disable. > IIRC it was without the lock in early stages of development (pre upstream git, so you can't see it) which had some obvious races. > But the lock makes it mutually exclusive per vcpu and should ensure it isn't running - by that it should be fine. > > Reviewed-by: Christian Ehrhardt <ehrhardt@xxxxxxxxxxxxxxxxxx> Ok, applied on my kvm ppc branch. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
