On 2/17/09, Liu Yu <yu.liu@xxxxxxxxxxxxx> wrote: > This patch add the emulation of freescale's pci controller for E500 platform. > > Signed-off-by: Liu Yu <yu.liu@xxxxxxxxxxxxx> A reset function (registered with qemu_register_reset) would be nice. > + * Copyright (C) 2009 Freescale Semiconductor, Inc. All rights reserved. "All rights reserved" conflicts with GPL. > + d->config[0x00] = 0x57; // vendor_id > + d->config[0x01] = 0x19; > + d->config[0x02] = 0x30; // device_id > + d->config[0x03] = 0x00; Please use pci_config_set_vendor_id and pci_config_set_device_id functions and add the ID #defines to hw/pci.h. > + d->config[0x0a] = 0x20; // class_sub = other bridge type > + d->config[0x0b] = 0x0B; // class_base = PCI_bridge I'd think these should be 0x06 (PCI_BASE_CLASS_BRIDGE) and 0x04 (PCI_CLASS_BRIDGE_PCI). Are these correct? -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
