On Fri, 2009-01-09 at 15:56 +0800, Liu Yu wrote:
> As host and guest have different fdt path,
> E500 can't use kvmppc_fdt_update(),
> but to use kvmppc_read_host_proper lonely.
>
> Signed-off-by: Liu Yu <yu.liu@xxxxxxxxxxxxx>
> ---
> target-ppc/kvm_ppc.c | 4 ++--
> target-ppc/kvm_ppc.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/target-ppc/kvm_ppc.c b/target-ppc/kvm_ppc.c
> index 0caa5b9..82c0f42 100644
> --- a/target-ppc/kvm_ppc.c
> +++ b/target-ppc/kvm_ppc.c
> @@ -22,12 +22,12 @@ static QEMUTimer *kvmppc_timer;
> static unsigned int kvmppc_timer_rate;
>
> #ifdef HAVE_FDT
> -static int kvmppc_read_host_property(const char *node_path, const char *prop,
> +int kvmppc_read_host_property(const char *node_path, const char *prop,
> void *val, size_t len)
> {
> char *path;
> FILE *f;
> - int ret;
> + int ret = 0;
> int pathlen;
>
> pathlen = snprintf(NULL, 0, "%s/%s/%s", PROC_DEVTREE_PATH, node_path, prop)
Bug fixes like these should be in a separate patch and sent at the
*beginning* of the series, not the end.
> diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h
> index e536a88..3792ef7 100644
> --- a/target-ppc/kvm_ppc.h
> +++ b/target-ppc/kvm_ppc.h
> @@ -11,5 +11,7 @@
>
> void kvmppc_init(void);
> void kvmppc_fdt_update(void *fdt);
> +int kvmppc_read_host_property(const char *node_path, const char *prop,
> + void *val, size_t len);
>
> #endif /* __KVM_PPC_H__ */
So this means your earlier patches don't even build? The point of a
patch series is to keep the tree working at every step, so this patch
should appear before the e500 patch that uses it.
Similarly, your new PCI code and Makefile changes should all appear in
one patch. Right now you define PCI structures in one, PCI emulation in
another, and don't even built it until a third...
--
Hollis Blanchard
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
