RE: [PATCH 07/11] E500 TLB emulation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2008-12-16 at 18:08 +0800, Liu Yu wrote:
> 
> > To fix this, instead of doing error-checking in all these 
> > sites, I would
> > just mask with 1 instead of 3.
> > 
> 
> If the guest instruction appoint MAS0[TLBSEL] = 2 or 3,
> I think the best way is to ignore it.

Masking with 1 instead of 3 will ignore it. Or do you mean completely
ignore the instruction? The mask is and simpler and faster, and also
perfectly legal (it was a software error to begin with).

Actually, my e500 user manual (covering v1 and v2) says the TLBSEL field
is only 1 bit wide, with reserved bits on either side. So masking with 1
is clearly the right solution.

-- 
Hollis Blanchard
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux