Re: [PATCH 04/11] Put iccci into CONFIG_44x ifdef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-12-11 at 17:11 +0800, Liu Yu wrote:
> E500 deosn't support this instruction.
> 
> Signed-off-by: Liu Yu <yu.liu@xxxxxxxxxxxxx>
> ---
>  arch/powerpc/kvm/booke_interrupts.S |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/kvm/booke_interrupts.S
> b/arch/powerpc/kvm/booke_interrupts.S
> index 084ebcd..4679ec2 100644
> --- a/arch/powerpc/kvm/booke_interrupts.S
> +++ b/arch/powerpc/kvm/booke_interrupts.S
> @@ -347,7 +347,9 @@ lightweight_exit:
>  	lwz	r3, VCPU_SHADOW_PID(r4)
>  	mtspr	SPRN_PID, r3
> 
> +#ifdef CONFIG_44x
>  	iccci	0, 0 /* XXX hack */
> +#endif
> 
>  	/* Load some guest volatiles. */
>  	lwz	r0, VCPU_GPR(r0)(r4)

You know, I had thought this was unnecessary, and I was going to remove
it. However, it looks like the 440 must invalidate the icache any time
an (executable) translation changes.

Technically we could handle this like the kernel does with
icache_44x_need_flush, but I don't think we're losing much by just
leaving this ifdef here.

-- 
Hollis Blanchard
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM Development]     [KVM ARM]     [KVM ia64]     [Linux Virtualization]     [Linux USB Devel]     [Linux Video]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux