Good catch. > -----Original Message----- > From: kvm-ppc-owner@xxxxxxxxxxxxxxx > [mailto:kvm-ppc-owner@xxxxxxxxxxxxxxx] On Behalf Of Hollis Blanchard > Sent: Tuesday, November 25, 2008 1:38 AM > To: Avi Kivity > Cc: kvm-ppc; kvm > Subject: [PATCH] kvm: ppc: stop leaking host memory on VM exit > > When the VM exits, we must call put_page() for every page > referenced in the > shadow TLB. > > Without this patch, we usually leak 30-50 host pages (120 - > 200 KiB with 4 KiB > pages). The maximum number of pages leaked is the size of our > shadow TLB, 64 > pages. > > Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx> > --- > The obvious question is "why didn't we see this before?" > Basically, we'd never > looked for it, and since most of our work was in the kernel > we always ended up > rebooting before exhausting host memory. > > Since it's such a large leak, and a simple fix, please commit > this for 2.6.28. > This patch does apply to kvm.git with fuzz, but if you prefer > I can send a > separate patch for that later. > -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
