On Fri, 2008-08-22 at 17:10 +0800, Liu Yu wrote: > > > +#define mtdcr(rn, val) > > > > > > > define mtdcr to what ? > > To null. I think it return void. > E500 doesn't support dcr. > Finally there is a place could be simpler than 44x. :-) It would be better to ifdef or abstract the DCR code in emulate.c so that it's not compiled on e500. The same goes for emulation of e500-specific instructions (probably just SPRs like EPR) on 440 -- I think we should split kvmppc_emulate_instruction() somehow. There's an open question about being able to run e.g. a 440 guest on an e500 host, but since nobody I've talked to seems interested in that I think it's OK not to allow that for now. (However, I do want to make sure our design/layering allows for that at some point in the future, if it becomes interesting.) -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
